chain: remove TxStatusError::InvalidTx variant #7915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TxStatusError::InvalidTx variant is never constructed so get rid of it.
|
One Q I have here is what actually happens then, if the tx is indeed invalid? As in, maybe the bug is that we don't construct this variant, and we really should? |
|
My understanding is that this error happens when you’re submitting a transaction. It may not happen when you query transaction’s status since if you specify invalid hash you’ll get missing transaction error. |
matklad
approved these changes
Oct 24, 2022
|
Right, if tx is invalid, we won't even store it |
nikurt
pushed a commit
that referenced
this pull request
Oct 25, 2022
The TxStatusError::InvalidTx variant is never constructed so get rid of it.
nikurt
pushed a commit
that referenced
this pull request
Nov 7, 2022
The TxStatusError::InvalidTx variant is never constructed so get rid of it.
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
The TxStatusError::InvalidTx variant is never constructed so get rid of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TxStatusError::InvalidTx variant is never constructed
so get rid of it.