store: adding State to cold columns #7926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don’t think this is true. Or at least it won’t be true once sharding happens. Shard layout comes from runtime adapter I think. |
mina86
reviewed
Oct 25, 2022
mina86
reviewed
Oct 25, 2022
mina86
approved these changes
Oct 26, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 7, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding DBCol::State to cold columns.
To determine which keys should be updated for State we read TrieChanges.
Because TrieChanges also contain values that are written there is no need to actually read State column from hot storage. Rather it is more efficient to write those values from TrieChanges to store cache.
Also, shard uids are needed to read TrieChanges at least, so we requiere SharLayout to be passed to update function.
Technically, to construct ShardLayout we only need epoch id and genesis config, I think, so we can pass just config and construct ShardLayout inside update function, but it is easier now to just pass ShardLayout.