migrated connect_to_unbanned_peer test #8196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
requested review from
mzhangmzz,
saketh-are and
mm-near
and removed request for
mzhangmzz
saketh-are
approved these changes
Dec 9, 2022
| if let Err(err) = self.state.peer_store.update_connected_peers_last_seen(&self.clock) { | ||
| tracing::error!(target: "network", ?err, "Failed to update peers last seen time."); | ||
| } | ||
| self.state.peer_store.update(&self.clock); |
There was a problem hiding this comment.
This is a nice simplification moving all the updates to one function.
| @@ -100,7 +100,7 @@ pub(crate) enum ClosingReason { | |||
| #[error("Received a message of type not allowed on this connection.")] | |||
| DisallowedMessage, | |||
| #[error("PeerManager requested to close the connection")] | |||
| PeerManager, | |||
| PeerManagerRequest, | |||
| tracing::info!(target:"test", "pm0 reconnects to pm1"); | ||
| pm0.connect_to(&pm1.peer_info(), tcp::Tier::T2).await; | ||
|
|
||
| drop(pm0); |
There was a problem hiding this comment.
Is it necessary to drop these manually?
There was a problem hiding this comment.
here is the context:
mm-near
approved these changes
Dec 9, 2022
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 14, 2022
Migrated connect_to_unbanned_peer test from integration-tests to near-network. It was flaky when executed in presubmit. I've made it more synchronized and faked out time, so now it shouldn't cause problems any more. I've tested it locally for flakiness (multiple concurrent runs in a loop) and observed no problems. To accomodate the test logic, I reorganized a bit the implementation of some PeerStore methods, but no semantic change was introduced there.
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 23, 2022
Migrated connect_to_unbanned_peer test from integration-tests to near-network. It was flaky when executed in presubmit. I've made it more synchronized and faked out time, so now it shouldn't cause problems any more. I've tested it locally for flakiness (multiple concurrent runs in a loop) and observed no problems. To accomodate the test logic, I reorganized a bit the implementation of some PeerStore methods, but no semantic change was introduced there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated connect_to_unbanned_peer test from integration-tests to near-network.
It was flaky when executed in presubmit. I've made it more synchronized and faked out time, so now it shouldn't cause problems any more. I've tested it locally for flakiness (multiple concurrent runs in a loop) and observed no problems.
To accomodate the test logic, I reorganized a bit the implementation of some PeerStore methods, but no semantic change was introduced there.