Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIER1 debug: fix usage of AccountKey vs PeerId #8220

Merged
merged 2 commits into from
Dec 14, 2022
Merged

TIER1 debug: fix usage of AccountKey vs PeerId #8220

merged 2 commits into from
Dec 14, 2022

Conversation

saketh-are
Copy link
Collaborator

This PR corrects usage of AccountKey and PeerId in the TIER1 debug page.

Sample pending TIER1 connections:
Screen Shot 2022-12-13 at 5 44 08 PM

Sample after connections are established:
Screen Shot 2022-12-13 at 5 44 32 PM

@saketh-are saketh-are marked this pull request as ready for review December 14, 2022 15:45
@saketh-are saketh-are requested a review from a team as a code owner December 14, 2022 15:45
@saketh-are saketh-are requested review from akhi3030 and pompon0 and removed request for akhi3030 December 14, 2022 15:45
pompon0
pompon0 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@near-bulldozer near-bulldozer bot merged commit 9f0f36a into near:master Dec 14, 2022
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Dec 19, 2022
@saketh-are @nikurt
TIER1 debug: fix usage of AccountKey vs PeerId (near#8220)
47fdfe3 
This PR corrects usage of AccountKey and PeerId in the TIER1 debug page.

Sample pending TIER1 connections:
<img width="1090" alt="Screen Shot 2022-12-13 at 5 44 08 PM" src="https://user-images.githubusercontent.com/3241341/207462241-f4c45ca4-0ce2-43bf-800a-d74bef1511cd.png">

Sample after connections are established:
<img width="1117" alt="Screen Shot 2022-12-13 at 5 44 32 PM" src="https://user-images.githubusercontent.com/3241341/207462253-da4266d5-687f-4809-8b31-f83d2bb98712.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saketh-are @pompon0