chore: tokio patch version update to 1.18.4 #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaces near#8304 dependabot made us aware of bugfixes and wanted to update to 1.20.3 Instead I propose we update only the patch version and keep major/minor. 1.18.x is a LTS version and it is what we are currently using. Updating further should be done as a conscious decision. `version = "~1.18"` means we want a fixed 1.18 minor version with the newest patch version. The old `"1.16.1"` is equivalent to `^1.16.1"` but in the lock file it was fixed to `"1.18.2"`. Since we check in the lock file and only update versions occasionally and consciously, I suggest we use `~` which is less confusing.
jakmeier
added
the
C-dependencies
near-bulldozer bot
pushed a commit
that referenced
this pull request
May 8, 2023
[Audits](https://github.com/near/near-sdk-rs/actions/runs/4690517670/jobs/8376852068?pr=1010) in `near-sdk` highlight a security vulnerability [RUSTSEC-2023-0001](https://rustsec.org/advisories/RUSTSEC-2023-0001) that affects the Windows platform. As far as I could tell, we're not directly impacted by this, but the severity suggests we make an upstream dep update. #8309 (comment) pinned `tokio` to `1.18` and suggested not updating the minor version unconsciously. Whereas #8472 required a bump to `1.19`, which has no versions that patch this vulnerability. This PR seizes the opportunity to re-pin the minor version to the latest, after which subsequent updates can uphold the bump requirement outlined in #8309.
nikurt
pushed a commit
that referenced
this pull request
May 10, 2023
[Audits](https://github.com/near/near-sdk-rs/actions/runs/4690517670/jobs/8376852068?pr=1010) in `near-sdk` highlight a security vulnerability [RUSTSEC-2023-0001](https://rustsec.org/advisories/RUSTSEC-2023-0001) that affects the Windows platform. As far as I could tell, we're not directly impacted by this, but the severity suggests we make an upstream dep update. #8309 (comment) pinned `tokio` to `1.18` and suggested not updating the minor version unconsciously. Whereas #8472 required a bump to `1.19`, which has no versions that patch this vulnerability. This PR seizes the opportunity to re-pin the minor version to the latest, after which subsequent updates can uphold the bump requirement outlined in #8309.
Given that parts of nearcore are released as crates and re-used in ecosystem, we should avoid pinning the dependencies unless there is a good reason for that. I vote for removing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #8304
dependabot made us aware of bugfixes and wanted to update to 1.20.3
Instead I propose we update only the patch version and keep major/minor.
1.18.x is a LTS version and it is what we are currently using.
1.18.4 contains the same fixes the bot wants.
Updating further should be done as a conscious decision.
version = "~1.18"means we want a fixed 1.18 minor version withthe newest patch version.
The old
"1.16.1"is equivalent to^1.16.1"but in the lock file itwas fixed to
"1.18.2". Since we check in the lock file and only updateversions occasionally and consciously, I suggest we use
~which isless confusing.