refactor: Implement TryFrom for ParameterValue #8420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
TryFrom
forParameterValue
for a few types that we need while working withParameterTable
.This helps to get rid of a lot of duplication in
get_*
methods, but I wasn't able to get rid ofget_number
that is already generic as it was violating Rust foreign trait rules (see commented out code, the exact error is [1]). Any advice there?I also feel that
TryFrom
implementations have a bit more duplication thanas_*
methods that we had before. Particularly in re-defining the error type each time and constructing very similar error messages. Any advice here would be appreciated.[1]