Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update delegate action gas cost #8597

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

jakmeier
Copy link
Contributor

for estimation data, please refer to
#8114 (comment)

for estimation data, please refer to
near#8114 (comment)
@jakmeier jakmeier requested a review from a team as a code owner February 17, 2023 21:43
@jakmeier jakmeier linked an issue Feb 17, 2023 that may be closed by this pull request
4 tasks
@jakmeier
Copy link
Contributor Author

@akhi3030 this is one of the PRs mentioned (the other isn't ready yet)

Here I just update the gas costs to the findings reported here: #8114 (comment)

The estimation code itself is not merged, yet. It is good enough to manually run it and learn the upper ends of the distribution for execution time. But it's still quite flaky, the high variance would probably show up in the automated continuous estimation checks. I want to improve that but in terms of priority this comes after finalizing the gas costs numbers.

Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the conclusions drawn in #8114 (comment), this looks reasonable to me.

@near-bulldozer near-bulldozer bot merged commit 34ca6d8 into near:master Feb 20, 2023
@jakmeier jakmeier deleted the update-delegate-gas-cost branch February 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta-tx gas cost estimation
2 participants