feat: use split store in the view client #8656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wacban
commented
Feb 28, 2023
•
wacban
commented
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
wacban
force-pushed
the
waclaw-cold-view-client
branch
from
6093ed2 to
91521aa
Compare
|
Some tests were failing in nayduck so I hid the split storage in view client behind a config that by default is false. Also configured a few other split storage things that will be handy to tune tests. |
nikurt
approved these changes
Mar 2, 2023
core/store/src/lib.rs
Outdated
| Temperature::Cold => self.get_cold_store().unwrap(), | ||
| } | ||
| } | ||
| // pub fn get_store(&self, temp: Temperature) -> Store { |
nikurt
pushed a commit
that referenced
this pull request
Apr 14, 2023
- use split store in the view client - when configured - removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store - added SplitStorageConfig and used it to configure a few things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.