fix: State dump creates dumps at the correct point #8794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dump needs to be of the state at the beginning of the last block of the previous epoch.
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Mar 24, 2023
|
Please ping me when this PR is ready to be merged. |
marcelo-gonzalez
approved these changes
Mar 24, 2023
nearcore/src/state_sync.rs
Outdated
| let sync_prev_hash = sync_prev_header.prev_hash(); | ||
| let prev_sync_block = chain.get_block(&sync_prev_hash)?; | ||
| if runtime.cares_about_shard(None, prev_sync_block.header().prev_hash(), shard_id, false) { | ||
| assert_eq!(num_shards, prev_sync_block.chunks().len() as u64); |
There was a problem hiding this comment.
for this whole thing, did you consider just using Chain::get_state_response_part()? The logic around finding the right state roots and such is already implemented there, so you could just call that function in the main loop of state_sync_dump() if InProgress just stored the shard ID, part_id and sync_hash. Unless maybe I'm missing something
There was a problem hiding this comment.
Amazing suggestion. Done.
Using `get_state_response_header()` instead of reimplementing it.
|
@akhi3030 Please take a look |
akhi3030
approved these changes
Mar 27, 2023
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Apr 5, 2023
The dump needs to be of the state at the beginning of the last block of the previous epoch. Add latency metrics to functions `fn obtain_state_part()` and `fn apply_state_part()`. Improves debugging to be more verbose about which state root is used for dumping and application. Add a command `neard view-state state-parts read-state-header` to read a state header from the DB.
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Apr 6, 2023
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Apr 13, 2023
nikurt
added a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dump needs to be of the state at the beginning of the last block of the previous epoch.
Add latency metrics to functions
fn obtain_state_part()andfn apply_state_part().Improves debugging to be more verbose about which state root is used for dumping and application.
Add a command
neard view-state state-parts read-state-headerto read a state header from the DB.