treewide: use workspace dependencies #8822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekleog-NEAR
added
C-housekeeping
nagisa
reviewed
Mar 29, 2023
| memoffset = "0.6" | ||
| more-asserts = "0.2" | ||
| near-account-id = { path = "core/account-id", features = [ "internal_unstable" ] } |
There was a problem hiding this comment.
This is pretty nice. Features should always be specified by crates that require them, though.
There was a problem hiding this comment.
For features, is it a general comment, or a suggested change? In this specific case I think enabling the internal_unstable feature actually makes sense, as any .workspace = true dependency on it would necessarily be internal.
nagisa
approved these changes
Mar 29, 2023
|
Removed the automerge to give opportunity to address the comments. Feel free to re-add if you want to address these in a follow-up or something. |
|
Merging, I’ll remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promised follow-up of #8792. I migrated one crate per commit at the beginning, and when most crates did not lead to changes in the root-level Cargo.toml started migrating a few at once. Would recommend commit-by-commit review as I checked that cargo resolution didn’t change after each commit.
Given the bitrot potential I’m marking as automerge right now.