fix: exclude test WebAssembly from linguist #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
reviewed
Apr 3, 2023
.gitattributes
Outdated
| @@ -1 +1,2 @@ | |||
| **/package-lock.json linguist-generated=true -diff | |||
| /runtime/near-vm/tests/wast/spec/* linguist-detectable=false | |||
There was a problem hiding this comment.
I’d just ignore anything with **.wast, **.wat and **.wasm extensions. Given the nature of the project(s) these files can end up in other places just as well quite easily, leading to this same issue appearing again.
There was a problem hiding this comment.
that makes sense, done
pugachAG
changed the title
nagisa
approved these changes
Apr 3, 2023
|
The fix worked as expected: |
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Apr 5, 2023
Github displays nearcore language as WebAssembly which is confusing: <img width="464" alt="Screenshot 2023-04-03 at 11 49 02" src="https://user-images.githubusercontent.com/3171838/229474854-3597d9ec-6f7c-4efe-815c-11a3e4bee23d.png"> This is caused by near#8792. Fixed by ignoring test wast files.
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
Github displays nearcore language as WebAssembly which is confusing: <img width="464" alt="Screenshot 2023-04-03 at 11 49 02" src="https://user-images.githubusercontent.com/3171838/229474854-3597d9ec-6f7c-4efe-815c-11a3e4bee23d.png"> This is caused by #8792. Fixed by ignoring test wast files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github displays nearcore language as WebAssembly which is confusing:
This is caused by #8792.
Fixed by ignoring test wast files.