feature: Introduce a limit to transaction pool size #8970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
added
the
A-congestion
aborg-dev
force-pushed
the
tp_limit_size
branch
3 times, most recently
from
c3a56c9 to
3c518ff
Compare
aborg-dev
force-pushed
the
tp_limit_size
branch
10 times, most recently
from
c1c49ba to
8ae3079
Compare
nikurt
approved these changes
May 11, 2023
|
|
||
| /// If set, new transactions that bring the size of the pool over this limit will be rejected. | ||
| /// The size is tracked and enforced separately for each shard. | ||
| pool_size_limit: Option<u64>, |
There was a problem hiding this comment.
Do you know what is the largest valid transaction?
There was a problem hiding this comment.
I've seen the number "4MiB" mentioned a few times, e.g. in #8936 and
andnearcore/runtime/runtime/src/verifier.rs
Line 108 in e334efc
nikurt
approved these changes
May 11, 2023
- Add enum for different transaction outcomes - Introduce transaction pool size accounting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces a limit to the size of the transaction pool for each shard and a logic that rejects transactions that go over this limit. The reasoning for this work is described in #3284.
To start, the limit will be disabled (effectively set to infinity) and this PR shouldn't have any effect. The node operators can override it with a config option. In the future, we will come up with a safe value to set by default (probably between 10 MiB - 1 GiB).
We also start with a simple option where the RPC client will not know if their transaction runs into this limit. We will need to rework this part in the future, but it will have to touch the transaction forwarding code in a non-trivial way, and I would prefer to work on this when we have a congestion test ready #8920.
Lastly, this PR adds some nuance to handling reintroducing transactions back to the pool after reorg or producing a chunk (
reintroduce_transactionsmethod), by acknowledging that not all transactions might have been included and logging the number of dropped transactions.