fix: Handle size update on partial pool iterator update #9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the code had a leak in the `total_transaction_size` because we didn't update it when we were dropping the empty group from `sorted_groups`. Overall, I find the current implementation of transaction pool really tricky to work with and I'm more and more tempted to do near#9060 sooner.
jakmeier
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the code had a leak in the
total_transaction_sizebecause we didn't update it when we were dropping the empty group fromsorted_groups.Overall, I find the current implementation of transaction pool really tricky to work with and I'm more and more tempted to do #9060 sooner.