Fix type gen bug #449
Merged
Fix type gen bug #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
approved these changes
Dec 15, 2023
| setError(() => undefined); | ||
| } catch (error) { | ||
| handleCodeGenError(error); | ||
| setTypesGenerationError(() => undefined); |
There was a problem hiding this comment.
Suggested change
| setTypesGenerationError(() => undefined); | |
| setTypesGenerationError(undefined); |
Using a function is only necessary when you intend to use the existing state, i.e. (currentState) => currentState + 1
| async function handleFormating() { | ||
| await reformat(indexingCode, schema); | ||
| await reformatAll(indexingCode, schema); |
There was a problem hiding this comment.
Suggested change
| await reformatAll(indexingCode, schema); | |
| reformatAll(indexingCode, schema); |
This function is not async
darunrs
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
FYI, I tried to run the frontend locally again, since it's been a while. But, it wasn't loading for some reason. I did:
- yarn serve:widgets:local
- Set flag to http://127.0.0.1:3030
- Ran yarn dev in a separate terminal
- Visited localhost:3000.
I was stuck at the loading screen.
| handleCodeGenError(error); | ||
| setTypesGenerationError(() => undefined); | ||
| } catch (typesError) { | ||
| console.log("typesGenerationError generating types for saved schema.\n", typesError); |
There was a problem hiding this comment.
Should this be a console.error? Same for the others.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue where if the formatting of SQL is not current or we encounter a case in which we do not support the type generation library for the context method, we fail very abruptly.
This PR handles these errors better.