Fix loading a schema from registry #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 4, 2024 17:28
…nges on the indexerDetails object. - Show the schema even if it fails the validations
…api into fix/load-schema-from-registry # Conflicts: # frontend/src/components/Editor/Editor.jsx
darunrs
reviewed
Jan 5, 2024
roshaans
suggested changes
Jan 5, 2024
added 3 commits
January 5, 2024 14:57
… validation when user is changing the code
roshaans
suggested changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the issue here
Changes on this PR
Refactored Editor file,
-- remove side effects from reformatAll function, solving the main problem of the issue
-- simplified useEffects with logic related to loading the schema, separating concern and focusing them on only one task
-- remove dead code
-- simplified other functions
Refactored logic to validate the schema
-- only validate schemas different from the default
Fixed issue when generating types
Screen.Recording.2024-01-05.at.10.26.09.AM.mov