Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introducing Logging Class (Disabled Usage of Logger) #608
feat: Introducing Logging Class (Disabled Usage of Logger) #608
Changes from 3 commits
e49e4ae
cc7a10a
a82aa7b
4f33dd4
dc80f7e
56dea50
e1fb2e9
7648295
ad1f5ab
58623aa
039789d
81824ce
57b6bda
8afef13
cc37561
f3c4b37
7bb8e4e
4083dda
5265128
eea34ce
9d13c85
cf8803f
04a2eb3
f0f46f9
470eab3
849dec6
97390b0
c3b5f49
f609269
296401c
7254ad8
eff6eda
6aa96f1
d49cb12
a5e1af9
2190587
6574db8
b816f9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't imagine we'd have a single
IndexerLogger
instance log for multiple different indexers, it's really even possible given that each indexer has it's own thread.This would be better suited as a class property, which is passed in during construction, i.e. we instantiate an
IndexerLogger
for a particular Indexer. This would simplifyLogEntry
.