fix: Configure cron db from environment #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darunrs
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Nice! While you're here, you might want to also update the docker compose to specify your dockerfile instead of the postgres:14 image. I think the image tag is overriding the usage of your new postgres Dockerfile.
Think just need a small update to the integ tests too.
| } | ||
|
|
||
| const defaultConfig: Config = { | ||
| cronDatabase: process.env.CRON_DATABASE, | ||
| hasuraHostOverride: process.env.HASURA_HOST_OVERRIDE, | ||
| hasuraPortOverride: process.env.HASURA_POST_OVERRIDE ? Number(process.env.HASURA_POST_OVERRIDE) : undefined |
There was a problem hiding this comment.
nit: HASURA_PORT_OVERRIDE PORT vs POST
There was a problem hiding this comment.
Good catch, that's not a nit, that's a genuine error :D
morgsmccauley
commented
Apr 2, 2024
Comment on lines
44
to
45
| hasuraHostOverride: process.env.HASURA_HOST_OVERRIDE, | ||
| hasuraPortOverride: process.env.HASURA_POST_OVERRIDE ? Number(process.env.HASURA_POST_OVERRIDE) : undefined |
There was a problem hiding this comment.
This will be useful for local development, i.e. we start Runner outside of docker, and therefore need to use a different host/port` value to communicate with Postgres. These should only exist within local dev.
morgsmccauley
force-pushed
the
fix/local-pg-cron
branch
from
c97c2b4 to
03ee9a1
Compare
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin/cron connection is currently hard-coded to the
crondatabase, but this needs to be configurable so that we can use the default DB (postgres) locally.Additionally, this PR combines the
pgbouncer/pg_croninit scripts and uses the combined output in both docker compose and integration tests.