fix: type generation on load #648
Conversation
| return isPrimaryKey || isNullable ? false : true; | ||
| } | ||
|
|
||
| getRequiredStatus(columnDef, nullable) { | ||
| const hasDefaultValue = | ||
| columnDef.hasOwnProperty("default_val") && columnDef.default_val != null; | ||
| Object.prototype.hasOwnProperty.call(columnDef, "default_val") && |
There was a problem hiding this comment.
Modified all access methods to avoid shadowing
| } | ||
| } | ||
| } | ||
| dbSchema[tableName] = columns; | ||
| } else if (statement.type === "alter") { | ||
| // Process ALTER TABLE statements | ||
| let newConstraint = {}; |
There was a problem hiding this comment.
What's the point in moving the contraint variable outside the for loop? It's scope is to apply to the alterSpec in question.
There was a problem hiding this comment.
This was just due to a stricter eslint configuration where there was a lexical declaration inside a case block. To fix the issue, I moved the lexical declaration outside of the case block.
…s-are-not-generated-onload
Kevin101Zhang
requested review from
morgsmccauley and
darunrs
and removed request for
morgsmccauley
|
Sorry, let this sit and forgot about rerequesting are review here. Are we good to merge here? |
| @@ -141,11 +142,11 @@ export class PgSchemaTypeGen { | |||
| } | |||
|
|
|||
| addColumn(columnDef, columns) { | |||
| const columnName = columnDef.column.column.expr.value; | |||
| const columnName = columnDef.column.column; | |||
There was a problem hiding this comment.
Is this correct? I thought the location of the column name was changed after the update? Can you verify this is the right way to get the name?
There was a problem hiding this comment.
Yep! This should be it! I verified locally with the latest version we have of node-sql-parser and the object we from astify.
There was a problem hiding this comment.
confirmed by pulling and it works for me
The object post astify() we receive from node-sql-parser changed. We can think about Version Control in the future.
Quick fix here: returning the object to how it was and adding an additional layer on Editor to ensure mounting of types