-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Conditionally provision metadata table #658
Conversation
@@ -50,6 +50,7 @@ const defaultConfig: Config = { | |||
|
|||
export default class Indexer { | |||
DEFAULT_HASURA_ROLE: string; | |||
LOGGGED_CONTEXT_DB_WARNING: boolean = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep printing the warn log which says context db failed to build. This is helpful to know once in the event where an indexer somehow gets through publishing with context.db issues. We don't need it repeatedly playing.
This can be removed later when we refactor Indexer to build the context object once.
001cfa1
to
747c9b1
Compare
@@ -2,6 +2,16 @@ | |||
# It is not intended for manual editing. | |||
version = 3 | |||
|
|||
[[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't know what this change is but it keeps showing up in VS Code for some reason. It seems like its related to the new tracing stuff. I think my lock file is being auto generated without prompt and it keeps bugging me about the change.
Tested provisioning locally on partially provisioned and new indexers. Observed logs and metadata table were provisioned and tracked. |
Enable conditional provisioning of metadata table.