Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditionally provision metadata table #658

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Conversation

darunrs
Copy link
Collaborator

@darunrs darunrs commented Apr 11, 2024

Enable conditional provisioning of metadata table.

@darunrs darunrs changed the base branch from main to refactor-indexer-config April 11, 2024 21:00
@@ -50,6 +50,7 @@ const defaultConfig: Config = {

export default class Indexer {
DEFAULT_HASURA_ROLE: string;
LOGGGED_CONTEXT_DB_WARNING: boolean = false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep printing the warn log which says context db failed to build. This is helpful to know once in the event where an indexer somehow gets through publishing with context.db issues. We don't need it repeatedly playing.

This can be removed later when we refactor Indexer to build the context object once.

Base automatically changed from refactor-indexer-config to main April 11, 2024 22:37
@darunrs darunrs linked an issue Apr 11, 2024 that may be closed by this pull request
@darunrs darunrs force-pushed the provision-metadata-table branch from 001cfa1 to 747c9b1 Compare April 11, 2024 23:01
@darunrs darunrs marked this pull request as ready for review April 11, 2024 23:05
@darunrs darunrs requested a review from a team as a code owner April 11, 2024 23:05
@@ -2,6 +2,16 @@
# It is not intended for manual editing.
version = 3

[[package]]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know what this change is but it keeps showing up in VS Code for some reason. It seems like its related to the new tracing stuff. I think my lock file is being auto generated without prompt and it keeps bugging me about the change.

@darunrs
Copy link
Collaborator Author

darunrs commented Apr 11, 2024

Tested provisioning locally on partially provisioned and new indexers. Observed logs and metadata table were provisioned and tracked.

@darunrs darunrs merged commit e64bbfd into main Apr 12, 2024
7 checks passed
@darunrs darunrs deleted the provision-metadata-table branch April 12, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provision metadata tables
1 participant