Merge pull request #4 from near/fix-bf_set_ui

fix undefined behavior: shift 32 bits for uint32_t in bf_set_ui
near · Oct 10, 2022 · 572026e · 572026e
2 parents 83c426d + a2c07b9
commit 572026e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/libbf.c b/libbf.c
@@ -235,8 +235,13 @@ int bf_set_ui(bf_t *r, uint64_t a)
         a0 = a;
         a1 = a >> 32;
         shift = clz(a1);
+        // shift < 32 because a > 0xffffffff
         r->tab[0] = a0 << shift;
-        r->tab[1] = (a1 << shift) | (a0 >> (LIMB_BITS - shift));
+        if (shift == 0) {
+            r->tab[1] = a1;
+        } else {
+            r->tab[1] = (a1 << shift) | (a0 >> (LIMB_BITS - shift));
+        }
         r->expn = 2 * LIMB_BITS - shift;
     }
 #endif