Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows added to release build pipeline #5

Merged
merged 9 commits into from
Nov 8, 2022
Merged

windows added to release build pipeline #5

merged 9 commits into from
Nov 8, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Nov 3, 2022

No description provided.

@ailisp ailisp mentioned this pull request Nov 4, 2022
Merged
ailisp
ailisp approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Based on my experience, if the exe binary can be built with ubuntu mingw, it would work on windows - may require certain mingw dlls, but it would work.

@volovyks volovyks marked this pull request as ready for review November 8, 2022 11:25
@volovyks
Copy link
Collaborator Author

volovyks commented Nov 8, 2022

Good insight @ailisp, thanks!

@volovyks volovyks merged commit a6b155b into master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volovyks @ailisp