Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.9.8 Release (dev → main) #1109

Merged
merged 4 commits into from
May 30, 2024
Merged

v8.9.8 Release (dev → main) #1109

merged 4 commits into from
May 30, 2024

Conversation

ewiner
Copy link
Collaborator

@ewiner ewiner commented May 30, 2024

Description

Includes #1107 and version bump.

DO NOT MERGE until #1108 is merged. At that point I'll check the checklist so the build can succeed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Patrick1904
Patrick1904 previously approved these changes May 30, 2024
View reviewed changes
trechriron
trechriron previously approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trechriron trechriron dismissed stale reviews from Patrick1904 and themself via e9039d9 May 30, 2024 16:00
trechriron
trechriron approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after version bump.

@trechriron trechriron merged commit ae7f7ac into main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trechriron trechriron trechriron approved these changes

@Patrick1904 Patrick1904 Patrick1904 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewiner @trechriron @Patrick1904 @paouvrard