Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release #151

Closed
Ekleog-NEAR opened this issue Dec 2, 2022 · 7 comments
Closed

Make a release #151

Ekleog-NEAR opened this issue Dec 2, 2022 · 7 comments
Assignees

Comments

@Ekleog-NEAR
Copy link
Contributor

Ekleog-NEAR commented Dec 2, 2022

We should make a wasmer release.

This is currently blocked on:

Then we can make a release.

Once it’s done, we should be able to merge wasmer into the nearcore repository to simplify development

@Ekleog-NEAR Ekleog-NEAR self-assigned this Dec 2, 2022
@jakmeier
Copy link

jakmeier commented Dec 2, 2022

We decide how we want to behave when wasmer changes behavior between one version and the next

Sadly we didn't have time to discuss this today in the meeting, I guess we can wait until next week.

But just to clarify, do we expect this update to be a non-protocol update?

  • If yes, how can we be sure?
  • If no, well then I guess we have to talk about how we support replayability and such, which we could do in next week's meeting.

@Ekleog-NEAR
Copy link
Contributor Author

It can definitely wait until next week! We’re blocked on quite a lot of other things before being able to make a release anyway :)

The questions you have are all good questions, and especially the wasmparser bump makes me think this should be a protocol update. In addition to that the next thing I’ll be working on is trying to integrate @nagisa’s work on finite-wasm into wasmer, which if landed before the next version can happen would very much definitely be a protocol update. (But then the good thing is it’d be so big that it’d deserve having a "wasmer3")

Hence why I’ve been putting discussing what we want to do upon wasmer changes on the sync agenda for a few weeks, but didn’t push it more as we still have lots of time before being unblocked by other things anyway 😄

@akhi3030
Copy link

akhi3030 commented Dec 9, 2022

As per near/node-docs#55 (comment), this is currently blocked till the next nearcore release.

@Ekleog-NEAR
Copy link
Contributor Author

Ekleog-NEAR commented Mar 10, 2023

This is currently being replaced by work in progress in near/nearcore#8323, vendoring wasmer into nearcore

@nagisa
Copy link
Collaborator

nagisa commented Apr 24, 2023

Closing as near-vm has been merged into nearcore.

@nagisa
Copy link
Collaborator

nagisa commented Jun 27, 2023

Bad bot!

@nagisa
Copy link
Collaborator

nagisa commented Jun 29, 2023

Go. AWAY!

@nagisa nagisa closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants