Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also require BMI1 and LZCNT instructions #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ekleog-NEAR
Copy link

@Ekleog-NEAR Ekleog-NEAR commented Oct 14, 2022

Note: the intel manual calls this CPUID bit LZCNT, but linux calls it ABM. Following the intel manual in the CPU feature table.

Note: the intel manual calls this CPUID bit LZCNT, but the linux calls it ABM. Following the intel manual in the CPU feature table.
@render
Copy link

render bot commented Oct 14, 2022

@Ekleog-NEAR
Copy link
Author

This is required by near/wasmer#145, and given the feature is now 9 years old, it should be reasonable enough to assume it. I checked that on the machine we recommend on GCP it is present indeed.

@akhi3030
Copy link

akhi3030 commented Dec 9, 2022

CC: @Ekleog-NEAR chatted with Chetana and @gmilescu. We are waiting for the 1.30 (or 1.31) nearcore release and then we can revisit this issue.

@Ekleog-NEAR
Copy link
Author

Chatting with @gmilescu : The plan is to:

  1. Get the PR integrating that with nearcore ready and land it
  2. At the N-1 release, send an announcement to validators warning them of the change
  3. Release these changes in the N release

@Ekleog-NEAR
Copy link
Author

@gmilescu The changes will be released in the next release we cut, that is due tomorrow :) AFAICT that means now is the right time to announce it to validators, so that they have time to check their hardware is fine before it hits mainnet.

@Ekleog-NEAR
Copy link
Author

@gmilescu The changes are in 1.35, and this time there’s little likelihood that we’ll roll them back. Should we merge this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants