Skip to content

Commit

Permalink
zkasm: address compilation failures in the backend after merge
Browse files Browse the repository at this point in the history
  • Loading branch information
nagisa committed Oct 27, 2023
1 parent b526ca7 commit ec14b75
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cranelift/codegen/src/isa/zkasm/inst/emit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ impl MachInstEmit for Inst {
// For now we only support calls.
assert!(info.opcode.is_call());
sink.add_call_site(info.opcode);
sink.add_reloc(Reloc::RiscvCall, &info.dest, 0);
sink.add_reloc(Reloc::RiscvCallPlt, &info.dest, 0);
// This will be patched externally to do a necessary jump.
put_string(&format!("; CALL {name}\n"), sink);

Expand Down
4 changes: 4 additions & 0 deletions cranelift/codegen/src/isa/zkasm/inst/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,10 @@ impl MachInst for Inst {
preferred: 4,
}
}

fn is_mem_access(&self) -> bool {
todo!("FILL ME OUT")
}
}

//=============================================================================
Expand Down

0 comments on commit ec14b75

Please sign in to comment.