Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update French translation #137

Merged
merged 8 commits into from
Feb 24, 2024
Merged

Update French translation #137

merged 8 commits into from
Feb 24, 2024

Conversation

MaisClement
Copy link
Contributor

Hi,

This is just a little update of the french translation 😄

ShortDevelopment
ShortDevelopment requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@ShortDevelopment ShortDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you very much for your contribution!

There are some minor things to fix:

  • The compiler does not allow unescaped apostrophs ' in xml
    You can replace them with ’ or escape them with \'
  • "Windows" has been removed from the app name for clarity

Nearby Sharing Windows/Resources/values-fr/strings.xml Outdated Show resolved Hide resolved
Nearby Sharing Windows/Resources/values-fr/strings.xml Outdated Show resolved Hide resolved
Nearby Sharing Windows/Resources/values-fr/strings.xml Outdated Show resolved Hide resolved
Nearby Sharing Windows/Resources/values-fr/strings.xml Outdated Show resolved Hide resolved
@MaisClement
Copy link
Contributor Author

Hi,
I'm taking your review into consideration, let me know if there is anything else wrong.

ShortDevelopment
ShortDevelopment approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@ShortDevelopment ShortDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ShortDevelopment ShortDevelopment merged commit 9006af9 into nearby-sharing:master Feb 24, 2024
3 checks passed
@5T748CowJuy
Copy link

Thank you.. I will need to look up translations moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShortDevelopment ShortDevelopment ShortDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaisClement @5T748CowJuy @ShortDevelopment