chore: replace set-output #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
reviewed
Oct 24, 2022
| @@ -83,7 +83,7 @@ runs: | |||
| if: ${{ github.event_name == 'workflow_dispatch' }} | |||
| run: | | |||
| npm version --no-git-tag-version ${{ inputs.semver }} | |||
| echo "::set-output name=PACKAGE_VERSION::$(echo $(node -p "require('./package.json').version"))" | |||
| echo "PACKAGE_VERSION=$(echo $(node -p "require('./package.json').version"))" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
can you check if this command still works properly? I realize it's very similar to the previous one, but the nested double quotes are a little suspicious
There was a problem hiding this comment.
Running the shell command in this same repository gets "PACKAGE_VERSION=3.2.4", which is correct
simoneb
approved these changes
Oct 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions: Deprecating save-state and set-output commands.
GitHub actions using the mentioned commands will start to fail from 1st of June of 2023.
Reference