Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passphrase protected keys #117

Merged
merged 12 commits into from
Oct 29, 2021
Merged

Conversation

radomird
Copy link
Contributor

Adding support for passphrase protected keys.
Closes #116

@radomird radomird marked this pull request as ready for review October 29, 2021 08:23
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, see inline comments

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/verifier.spec.js Outdated Show resolved Hide resolved
test/verifier.spec.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs things, rest LGTM!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
radomird and others added 2 commits October 29, 2021 12:19
Co-authored-by: Shogun <ShogunPanda@users.noreply.github.com>
Co-authored-by: Shogun <ShogunPanda@users.noreply.github.com>
@radomird radomird merged commit dddd103 into master Oct 29, 2021
@radomird radomird deleted the support-pass-protected-keys branch October 29, 2021 14:39
@github-actions github-actions bot mentioned this pull request Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support for password protected private keys
3 participants