Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missingRequiredClaim to TokenValidationErrorCode #403

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: add missingRequiredClaim to TokenValidationErrorCode #403

merged 1 commit into from
Nov 7, 2023

Conversation

TimLehner
Copy link
Contributor

@TimLehner TimLehner commented Nov 7, 2023

This better reflects the actual source implementation and fixes #402.

The unit test is somewhat brittle, since it's too trusting of the .d.ts types. I don't know how to overcome this limitation without just typing the whole project properly

 this better reflects the actual source implementation
The unit tests is somewhat brittle, since it's too trusting of the .d.ts types.
I don't know how to overcome this limitation without just typing the whole project properly
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👌

@simoneb simoneb merged commit 4d8c66f into nearform:master Nov 7, 2023
6 of 8 checks passed
@TimLehner
Copy link
Contributor Author

When would I be likely to see this in a release?

@simoneb
Copy link
Member

simoneb commented Nov 8, 2023

We follow a release schedule, so it will be a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TokenValidationErrorCode types do not overlap with TOKEN_ERROR_CODES from source
2 participants