fix(typescript): fix typescript type DecodedJwt #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Nov 14, 2023
There was a problem hiding this comment.
can you please add types tests to https://github.com/nearform/fast-jwt/blob/master/test/types.spec.ts?
|
Please link the issue that this PR fixes, too |
|
I'm not sure why this change would fix your issue. Can you create a test which fails with the existing code, and succeeds with your change? |
simoneb
reviewed
Nov 17, 2023
|
I changed the pull request to just fix the payload type |
|
I've added a type test for that |
simoneb
approved these changes
Nov 17, 2023
|
tests are failing, can you take a look please? |
|
lint errors should be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #409