Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure required claims applies to custom claims #423

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: Ensure required claims applies to custom claims #423

merged 1 commit into from
Feb 15, 2024

Conversation

kieranm
Copy link
Contributor

@kieranm kieranm commented Feb 15, 2024

This PR ensures that custom claims are checked if they are specified in requiredClaims. Previously only a small subset of claims were validated.

Fixes #422

@kieranm kieranm changed the title Ensure required claims applies to custom claims fix: Ensure required claims applies to custom claims Feb 15, 2024
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🚀

@simoneb simoneb merged commit 3409d1d into nearform:master Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requiredClaims: Not all claims are checked
2 participants