Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbf claim not used when passed on the payload (solve #453) #454

Merged
merged 2 commits into from
Jul 15, 2024
Merged

nbf claim not used when passed on the payload (solve #453) #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ffeedf
fix #453: use nbf claim if present on body, solve false positive test…
JacopoPatroclo Jul 5, 2024
debf5ce
feat: test back and forth jwt parsing to check consistency
JacopoPatroclo Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/signer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function sign(
...fixedPayload,
iat: noTimestamp ? undefined : Math.floor(iat / 1000),
exp: payload.exp ? payload.exp : expiresIn ? Math.floor((iat + expiresIn) / 1000) : undefined,
nbf: notBefore ? Math.floor((iat + notBefore) / 1000) : undefined
nbf: payload.nbf ? payload.nbf : notBefore ? Math.floor((iat + notBefore) / 1000) : undefined
simoneb marked this conversation as resolved.
Show resolved Hide resolved
}

if (mutatePayload) {
Expand Down
27 changes: 27 additions & 0 deletions test/sign-decode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict'

const { test } = require('tap')

const { createDecoder, createSigner } = require('../src')

const secret = 'secret'
const decoder = createDecoder({ key: secret })
const signer = createSigner({ key: secret })

test('Should encode and decode the token, keeping a consistent payload', t => {
const p1 = {
a: 20,
iat: 999,
exp: 200000
}
t.strictSame(decoder(signer(p1)), p1)

const p2 = {
a: 'h',
iat: 999,
nbf: 999
}
t.strictSame(decoder(signer(p2)), p2)

t.end()
})
4 changes: 3 additions & 1 deletion test/signer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,12 +382,14 @@ test('it ignores invalid exp claim', async t => {
test('it adds a nbf claim, overriding the payload one, only if the payload is a object', async t => {
t.equal(
sign({ a: 1, iat: 100 }, { notBefore: 1000 }),
// jwt that contains nbf claim to be 1000
'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhIjoxLCJpYXQiOjEwMCwibmJmIjoxMDF9.WhZeNowse7q1s5FSlcMcs_4KcxXpSdQ4yqv0xrGB3sU'
)

t.equal(
sign({ a: 1, iat: 100, nbf: 200 }, { notBefore: 1000 }),
'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhIjoxLCJpYXQiOjEwMCwibmJmIjoxMDF9.WhZeNowse7q1s5FSlcMcs_4KcxXpSdQ4yqv0xrGB3sU'
// jwt that contains nbf claim to be 200
'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhIjoxLCJpYXQiOjEwMCwibmJmIjoyMDB9.HmHmbH-pOTlpj5FsVN61aT2PFhd6EN-tnQdExv_HUs4'
)
})

Expand Down
Loading