fix: update types to work with ESM + TS #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 242
Adds a namespace and declares
buildGetJwksso ESM + TS works.I'm not sure how to write tests for this issue because it requires changing
package.jsonto use ESM. See https://github.com/jmjf/get-jwks-demo README for how to demonstrate the issue and how to prove the fix works. LMK if you know of a better testing approach.I chose to declare all types, then export them in the namespace, as described in the README. Alternatively, I could declare and export the types in the namespace and change
declare function buildGetJwks...as described in the README if you prefer.