This repository has been archived by the owner on May 18, 2023. It is now read-only.
Improve mira test coverage #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokroger
commented
Jul 21, 2020
| @@ -135,9 +135,7 @@ export default class MiraConfig { | |||
| const envData: EnvData = loadEnvironment(envKey) | |||
| return massageEnvData(envData, false) | |||
| }) | |||
| if (!config.get('cicd.buildspec_file')) { | |||
| throw new Error('Missing config.cicd.buildspec_file') | |||
There was a problem hiding this comment.
This line will never be executed because the check is already being made on line 105
thiagokroger
force-pushed
the
improve-mira-test-coverage
branch
6 times, most recently
from
f097a57
to
5f60ca7
Compare
thiagokroger
force-pushed
the
improve-mira-test-coverage
branch
from
5f60ca7
to
ebeb4fe
Compare
|
Part of #19 |
irelandm
suggested changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting 100% on existing test files