-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ts migration #216
Feat/ts migration #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilteoood have you tested that this works with your changes? I wouldn't want to merge and release a new version just to realize that it doesn't work. I know that testing a CLI package is not the simplest thing, but just checking if you tried
@simoneb I tried the scripts included in the package.json, which involves some examples provided, but nothing more |
@ilteoood can you try using it as a binary, in the same way as it would be used by the end user? |
Hi @simoneb, I just tried it by both:
In both the scenario it is working fine. IMO we are ready to merge |
Closes #212
Closes #202
With this PR I aim to migrate everything to ts, including build steps and lint configurations.