Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set custom target when creating release #158

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

guilhermelimak
Copy link
Contributor

@guilhermelimak guilhermelimak commented Nov 8, 2022

Set the bump commit hash as release target to avoid merging the changes commited to the main branch after the release PR is created to be included in the release.

References nearform-actions/optic-release-automation-action#167

@guilhermelimak guilhermelimak self-assigned this Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@guilhermelimak guilhermelimak force-pushed the feat/add-branch-as-release-target branch from 0da2753 to 13dea8c Compare November 10, 2022 23:34
@guilhermelimak
Copy link
Contributor Author

@simoneb This is ready for review

index.test.js Show resolved Hide resolved
@simoneb
Copy link
Member

simoneb commented Nov 14, 2022

before we merge this, let's please give another thought about whether this is backwards compatible with the existing versions of the action circulating. I assume it is, but let's cross check as if that is not the case, everything will break

@guilhermelimak
Copy link
Contributor Author

before we merge this, let's please give another thought about whether this is backwards compatible with the existing versions of the action circulating. I assume it is, but let's cross check as if that is not the case, everything will break

I did test the backwards compatibility both ways but will do it again today just to make sure before deploying

@simoneb
Copy link
Member

simoneb commented Nov 14, 2022

we can merge then, deployment is only done after a release

@guilhermelimak
Copy link
Contributor Author

we can merge then, deployment is only done after a release

Just tested it again and all seems fine. I'll merge it

@guilhermelimak guilhermelimak merged commit 23682e6 into main Nov 14, 2022
@guilhermelimak guilhermelimak deleted the feat/add-branch-as-release-target branch November 14, 2022 16:40
@guilhermelimak guilhermelimak changed the title feat: set correct target when creating release feat: set custom target when creating release Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants