Parameter to ignore unchanged values #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in a fourth argument to the versioning function as `'true'`, if you want to ignore updates that don't actually update anything.
|
Proposed new feature in issue #10 |
|
Any feedback on this? |
|
@paolochiodi will you take a look at this please |
|
Could be nice if this was added to the versioning_no_checks_function as well |
|
@ps2goat - perhaps some unit tests would speed the merge of this? |
|
@PMLP-novo @ps2goat I have a new PR that includes these commits and adds tests: #20 I expect to merge it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can update other files to match this new functionality if you comment with your approval.
This takes an optional fourth parameter. If it equates to true, and an update is being performed, this will verify that something is different between the two rows before copying to the history table.