🐛: Quote the history table name

[afitzek]

In case the history table identifier needs quoting the function fails, because the generated statement is not valid. This should fix the problem.

Change-type: patch
Signed-off-by: Andreas Fitzek andreas.fitzek@reactivereality.com

[mrrinot]

I tested this and I had to add another quote_ident() around the history_table on this line

 WHERE  attrelid = history_table::regclass

[afitzek]

Thanks @mrrinot 👍
I also found a couple more places where this is needed and updated the PR. :)

[paolochiodi]

Hi @afitzek and @mrrinot thank for your comments and sorry for my late reply.

This seems to undo the work done in #21 where we removed all quoting as suggested by @yktv4 in a previous PR (#17) and issue #16

To me it seems a clearer and simpler solution to just provide the table name already quoted as a parameter to the trigger.

Have you tried that solution in the implementation without quote_ident?
Did you have any issue with that?

I'd be happy to hear your thinking on that.

[afitzek]

Hi @paolochiodi

First of all thank you for writing this library, it is very nice! :)

The solution to require the user to provide the correct quoted table name is also fine and I didn't think about the case where a user prefixes the table with the schema.

[simoneb]

@afitzek can we close this without merging?

[afitzek]

@simoneb Yes I think so, I forgot about this one.