-
Notifications
You must be signed in to change notification settings - Fork 1
Name clash demo #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name clash demo #20
Conversation
_ prefix indicated private method.
BSON bindings generation for NEAR
Implement nested objects support
Add diff to ./test.sh based on snapshots of output
AssemblyScript#429 This fix changes bindings generation to only generate each encode / decode function once, so that they don’t clash names.
Implement encode/decode sugar for generated bindings
To reproduce run |
|
@vgrichina It hard to investigate to this issue with bunch of generated code. It will be great if you reproduce this with minimal example ideally already pregenerated and compiled with original assemblyscript (without near-bindgen) |
@dcodeIO |
@MaxGraey did you try to have class with same name in 2 modules (one of them including another)? |
Yeah, tried |
@dcodeIO it's on GitHub. Am I doing |
Doesn't seem so, it's actually in $ ./test.sh
+ BASEDIR=../..
+ ../../bin/asc model.ts --nearFile model_near.ts
+ ../../bin/asc main.ts --nearFile main_near.ts
ERROR: Import file 'json/encoder.ts' not found.
at parseBacklog (xyz\assemblyscript\cli\asc.js:355:25) |
@dcodeIO I guess symlinks don't work in Git? |
That might be the issue, I'm on Windows |
@dcodeIO got it, then it should be enough just to copy files from |
969f500
to
f8c8736
Compare
Triggers AssemblyScript#429