Skip to content

Commit

Permalink
Use server name from display_name on create server + misc CI fixes (#217
Browse files Browse the repository at this point in the history
)

* Use server name from display_name on create server

* remove docker tests and ci misc

* bump version for rc6
  • Loading branch information
aktech authored Apr 8, 2024
1 parent a6c5f6f commit a6e40ce
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 32 deletions.
28 changes: 0 additions & 28 deletions .github/workflows/docker.yml

This file was deleted.

1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Lint

on:
push:
pull_request:

jobs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test-integration.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Test Integration

on:
push:
pull_request:

jobs:
Expand Down
2 changes: 1 addition & 1 deletion jhub_apps/__about__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2024.4.1rc5"
__version__ = "2024.4.1rc6"
4 changes: 3 additions & 1 deletion jhub_apps/service/routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ async def create_server(
thumbnail: typing.Optional[UploadFile] = File(None),
user: User = Depends(get_current_user),
):
logger.info("Creating server", server_name=server.servername, user=user.name)
# server.servername is not necessary to supply for create server
server_name = server.user_options.display_name
logger.info("Creating server", server_name=server_name, user=user.name)
server.user_options.thumbnail = await get_thumbnail_data_url(
framework_name=server.user_options.framework, thumbnail=thumbnail
)
Expand Down

0 comments on commit a6e40ce

Please sign in to comment.