-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 Page Simple #126
404 Page Simple #126
Conversation
@kildre is attempting to deploy a commit to the nebari-jhub-apps Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
jhub_apps/templates/404.html
Outdated
<div class="center-content-text v-center"> | ||
<h1 class="m-b-0">404 : PAGE NOT FOUND</h1> | ||
<h2>Sorry, the page you are looking for does not exist.</h2> | ||
<a href="/" role="link">Back to Home</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use the JupyterHub base_url here instead of /
. Suggest changing to this:
href="{{base_url}}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Addded a simple 404 page
Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?