Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot Updates #130

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Dependabot Updates #130

merged 2 commits into from
Feb 26, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Feb 26, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

  • Updated to group typescript eslint dependencies to prevent dependabot PRs with peerDependency issues from being created
  • Removed unneeded ignore for react-query

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 6:21pm
jhub-apps-docs ❌ Failed (Inspect) Feb 26, 2024 6:21pm

Copy link

vercel bot commented Feb 26, 2024

@jbouder is attempting to deploy a commit to the nebari-jhub-apps Team on Vercel.

A member of the Team first needs to authorize it.

@@ -20,4 +25,3 @@ updates:
- dependency-name: "@types/react-dom"
versions:
- ">=18.2.0"
- dependency-name: "@tanstack/react-query"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a carryover from another project. We should be including this in dependabot checks.

@aktech
Copy link
Member

aktech commented Feb 26, 2024

Seems like the integration tests are failing.

@aktech aktech merged commit 47b6c8e into nebari-dev:main Feb 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants