Spawner Profile page #135
Merged
Spawner Profile page #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io-button component with test. created a route to the servers type page
Merge branch 'main' into ui-spawner-profile-268
|
@kildre is attempting to deploy a commit to the nebari-jhub-apps Team on Vercel. A member of the Team first needs to authorize it. |
jbouder
requested changes
Feb 26, 2024
ui/src/index.css
Outdated
Comment on lines
84
to
85
| .button-container button { | ||
| } |
There was a problem hiding this comment.
This should be removed if not being used
| <div className="container mx-auto px-4"> | ||
| <div className="grid grid-cols-12 gap-4"> | ||
| <div className="col-start-4 col-span-6 bg-gray-200 p-4"> | ||
| <h1 className="mb-0">Hardware Environment</h1> |
There was a problem hiding this comment.
This should be Server Type...and maybe update the paragraph wording below
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Launching JupyterLab or VSCode will also hit the spawn page. Are those going to be the same as this one or different? Reason I'm asking is "create app" doesn't fit in those cases. |
jbouder
requested changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a page where the user can select a server type they would like to use for their application
Reference Issues or PRs
What does this implement/fix?
This removes the application server type selection from the form and puts it on its own page.
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?