Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tailwind References from App #148

Merged
merged 13 commits into from
Mar 12, 2024
Merged

Remove Tailwind References from App #148

merged 13 commits into from
Mar 12, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Mar 7, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-03-07 at 12 46 58 PM Screenshot 2024-03-07 at 12 47 11 PM Screenshot 2024-03-12 at 11 35 45 AM Screenshot 2024-03-07 at 12 56 02 PM

Any other comments?

  • Replaced all applicable custom components with MUI components
  • Replaced all use of tailwind utility classes with MUI components and custom classes
  • Updates to ensure consistent theming
  • Removed all tailwind dependencies
  • Misc UI updates to better support use of MUI components

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 3:34pm

@aktech
Copy link
Member

aktech commented Mar 12, 2024

I tried this locally, everything looks fine. This is good to merge, I have a minor comment.

@aktech
Copy link
Member

aktech commented Mar 12, 2024

@jbouder Quick question, we'll be styling this later?

Screenshot 2024-03-12 at 4 16 19 pm

Earlier it looked something like this:
Screenshot 2024-03-12 at 4 16 40 pm

@jbouder
Copy link
Collaborator Author

jbouder commented Mar 12, 2024

It was changed to a text, secondary styling based on recent feedback, which is what you see now. There are some inconsistencies in positioning and spacing between screens (forms, modals, etc), but this matches the current guidance

@aktech
Copy link
Member

aktech commented Mar 12, 2024

Thanks for clarification!

@aktech aktech merged commit 1d09aec into nebari-dev:main Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants