Implement new App Launcher Navigation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yout. Update jhub_apps to support new layout.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbouder
commented
Mar 14, 2024
Comment on lines
-6
to
-16
| return window.jhdata | ||
| ? window.jhdata | ||
| : JSON.parse(localStorage.getItem('jhdata') || '{}'); | ||
| }; | ||
|
|
||
| /** | ||
| * Store JupyterHub data in local storage for non-hub pages | ||
| * @param data | ||
| */ | ||
| export const storeJhData = (data: JhData) => { | ||
| localStorage.setItem('jhdata', JSON.stringify(data)); |
There was a problem hiding this comment.
Realized we had an endpoint for getting user data, so removed this and replaced with accessing from endpoint and storing in global storage
|
Can you merge the latest main, that's probably why the docs deployment is failing. |
|
nitpick: If there are too many of them on the sidebar, we can't see the last one: Screen.Recording.2024-03-20.at.10.18.11.am.mov |
|
The plan right now is to put the services under expandable sections, which would be collapsed by default, so that should help. We just don’t have the mechanism yet for categorization. That said, it might be worth mentioning during our design/dev sync this week as something to reconsider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
N/A
What does this implement/fix?
Put a
xin the boxes that applyTesting
Screenshots
Any other comments?