Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Query to v5 #170

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Upgrade React Query to v5 #170

merged 3 commits into from
Mar 21, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Mar 20, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

  • Updated @tanstack/react-query to latest
  • Updated axios to latest to resolve security vulnerability
  • Updated server types page with proper query declaration for v5
  • Fixed unit tests
  • Included new build

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:39pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:39pm

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like since the time you created this PR, they released another version: 5.28.6

Not expecting to upgrade in this PR, so I'll approve this.

@aktech aktech merged commit 23d4383 into nebari-dev:main Mar 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants