Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filtering and Sorting to App Cards #184

Merged
merged 16 commits into from
Mar 26, 2024
Merged

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Mar 25, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-03-26 at 10 15 44 AM Screenshot 2024-03-26 at 10 15 56 AM Screenshot 2024-03-26 at 10 16 26 AM

Any other comments?

  • Added Filter and Sort Menus
  • Updated layout to move Search and Add App to App Section
  • Added/Updated Tests
  • Misc refactoring

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 5:58pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 5:58pm

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tried it myself locally as well.

@aktech aktech merged commit 164d59a into nebari-dev:main Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants