Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Landing page & layout updates #213

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Apr 8, 2024

Documentation updates:

  • Clean up config, update footer links
  • Update landing page with supported frameworks

Note:

  • The landing page is using the same png files as the app launcher, and the files are copied to the docs folder because symlinks were not working as expected.
  • The page is not final by any means, just an option.

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 1:27pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 1:27pm

@pavithraes pavithraes changed the title Landing page & layout updates [DOCS] Landing page & layout updates Apr 10, 2024
@pavithraes pavithraes requested a review from aktech April 10, 2024 10:49
@pavithraes pavithraes added the area: documentation 📖 Improvements or additions to documentation label Apr 10, 2024
@pavithraes pavithraes marked this pull request as ready for review April 10, 2024 10:50
docs/src/pages/index.js Outdated Show resolved Hide resolved
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks great to me. I have a small nitpick comment.

@aktech
Copy link
Member

aktech commented Apr 10, 2024

You might want to merge the latest main to get rid of the failing test. The flakiness was fixed yesterday.

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@aktech aktech merged commit 65ca179 into nebari-dev:main Apr 10, 2024
13 checks passed
@aktech
Copy link
Member

aktech commented Apr 10, 2024

Excellent, looks great. Just noticed its your first contribution here. Welcome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants