Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server name from display_name on create server + misc CI fixes #217

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Use server name from display_name on create server + misc CI fixes #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
803b2dd
Use server name from display_name on create server
aktech Apr 8, 2024
56a0fea
remove docker tests and ci misc
aktech Apr 8, 2024
20790ae
bump version for rc6
aktech Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .github/workflows/docker.yml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Lint

on:
push:
pull_request:

jobs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Test Integration

on:
push:
pull_request:

jobs:
Expand Down
2 changes: 1 addition & 1 deletion jhub_apps/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2024.4.1rc5"
__version__ = "2024.4.1rc6"
4 changes: 3 additions & 1 deletion jhub_apps/service/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ async def create_server(
thumbnail: typing.Optional[UploadFile] = File(None),
user: User = Depends(get_current_user),
):
logger.info("Creating server", server_name=server.servername, user=user.name)
# server.servername is not necessary to supply for create server
server_name = server.user_options.display_name
logger.info("Creating server", server_name=server_name, user=user.name)
server.user_options.thumbnail = await get_thumbnail_data_url(
framework_name=server.user_options.framework, thumbnail=thumbnail
)
Expand Down
Loading