Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update docs pages #222

Merged
merged 7 commits into from
May 3, 2024
Merged

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Apr 9, 2024

This PR updates the documentation pages and structure.
There are also verified examples for Panel, Bokeh, and Gradio.

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link

vercel bot commented Apr 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 6 minutes (more than 100, code: "api-deployments-free-per-day").

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 5:54pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 5:54pm

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@pavithraes pavithraes changed the title Update app creation docs [DOCS] Update docs pages Apr 10, 2024
@pavithraes pavithraes marked this pull request as ready for review April 10, 2024 13:14
@pavithraes pavithraes requested review from aktech and kcpevey April 10, 2024 13:15
@pavithraes pavithraes added the area: documentation 📖 Improvements or additions to documentation label Apr 10, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: Moved all information into general-app.md and/or framework specific pages, hence removing this.

@kcpevey
Copy link
Contributor

kcpevey commented Apr 19, 2024

These look great @pavithraes! One thing I might suggest (up to you) is to maybe add the framework logo to the top of each doc page? There isn't a lot of color on these pages and that might liven it up and also provide some brand recognition to readers.

@kcpevey
Copy link
Contributor

kcpevey commented Apr 26, 2024

One thing I might suggest (up to you) is to maybe add the framework logo to the top of each doc page? There isn't a lot of color on these pages and that might liven it up and also provide some brand recognition to readers.

Regarding my suggestion above, I'm happy to leave this off for a future iteration so we can go ahead and get this merged. It will greatly help users to get these docs published!

@kcpevey
Copy link
Contributor

kcpevey commented Apr 26, 2024

@pavithraes I went ahead and pushed my changes since they were minor and I didn't think you'd mind. Do you want to take one final look?

@pavithraes
Copy link
Member Author

pavithraes commented May 3, 2024

@kcpevey Thanks for the updates, this looks good to me :)

@pavithraes pavithraes merged commit a04332e into nebari-dev:main May 3, 2024
13 checks passed
@pavithraes pavithraes deleted the docs-pages branch May 3, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants